Changed Json Serialization to System.Text.Json#5
Open
KaiBroeker wants to merge 1 commit intocmdotcom:masterfrom
Open
Changed Json Serialization to System.Text.Json#5KaiBroeker wants to merge 1 commit intocmdotcom:masterfrom
KaiBroeker wants to merge 1 commit intocmdotcom:masterfrom
Conversation
System.Text.Json ist faster then Newtonsoft.Json, so I changed the code to fit the new lib.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi togehter,
I have been using CM for some time, but via direct call and python. With the switch to C# I found this repo.
I have changed the code from Newtonsoft.Json to System.Text.Json. System.Text.Json is in comparisons faster than newtonsoft. This should speed up the execution, especially if you have to send many calls.
Furthermore System.Text.Json should be delivered with dotnet, so this lib would have less dependencies.
I tested the code with your test scripts and also the dtmf part productive in my application.
I hope the code meets your expectations.